[webkit-reviews] review granted: [Bug 232134] DisplayList::Recorder's clipBounds() becomes empty if a flip is applied to the CTM : [Attachment 442220] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 23 22:35:58 PDT 2021


Darin Adler <darin at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 232134: DisplayList::Recorder's clipBounds() becomes empty if a flip is
applied to the CTM
https://bugs.webkit.org/show_bug.cgi?id=232134

Attachment 442220: Patch

https://bugs.webkit.org/attachment.cgi?id=442220&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 442220
  --> https://bugs.webkit.org/attachment.cgi?id=442220
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442220&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:449
> +    if (std::optional<AffineTransform> inverse =
currentState().ctm.inverse())

I would’ve used auto here; writing out the type makes this code harder to read,
I think


More information about the webkit-reviews mailing list