[webkit-reviews] review granted: [Bug 232068] StreamConnectionWorkQueue is not thread-safe : [Attachment 441995] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 21 08:43:10 PDT 2021
Wenson Hsieh <wenson_hsieh at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 232068: StreamConnectionWorkQueue is not thread-safe
https://bugs.webkit.org/show_bug.cgi?id=232068
Attachment 441995: Patch
https://bugs.webkit.org/attachment.cgi?id=441995&action=review
--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 441995
--> https://bugs.webkit.org/attachment.cgi?id=441995
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=441995&action=review
> Source/WebKit/Platform/IPC/StreamConnectionWorkQueue.cpp:38
> + // `StreamConnectionWorkQueue::stop()` should be called if anything has
been dispatched or listened to.
Should this also assert `m_shouldQuit`?
More information about the webkit-reviews
mailing list