[webkit-reviews] review granted: [Bug 232080] Enable logging in under non-systemd linux distros : [Attachment 442026] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted ablocorrea at gmail.com's
request for review:
Bug 232080: Enable logging in under non-systemd linux distros
https://bugs.webkit.org/show_bug.cgi?id=232080

Attachment 442026: Patch

https://bugs.webkit.org/attachment.cgi?id=442026&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 442026
  --> https://bugs.webkit.org/attachment.cgi?id=442026
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442026&action=review

> w/Source/WTF/wtf/Logger.h:244
> -#if USE(SYSTEMD)
> +#if USE(JOURNALD)

If you're changing the name of the public build option to ENABLE_JOURNALD_LOG,
then also change its usage in the code to ENABLE(JOURNALD_LOG).

> w/Source/cmake/OptionsWPE.cmake:240
>	   SET_AND_EXPOSE_TO_BUILD(USE_JOURNALD TRUE)

Then here you would SET_AND_EXPOSE_TO_BUILD(ENABLE_JOURNALD_LOG TRUE)