[webkit-reviews] review granted: [Bug 231744] Remove Variant.h : [Attachment 441248] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 14 12:31:54 PDT 2021

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 231744: Remove Variant.h

Attachment 441248: Patch


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 441248
  --> https://bugs.webkit.org/attachment.cgi?id=441248

View in context: https://bugs.webkit.org/attachment.cgi?id=441248&action=review

I’d be surprised if there aren’t at least some cases where we can just do
without the include of <variant>, especially since including
<wtf/StdLibExtras.h> will now pull it in

> Source/WTF/wtf/StdLibExtras.h:32
> +#include <variant>

Too bad there’s no way to dodge this. I wonder what effect it has on build
times; what that tool Jer’s been using says about it. In the future, we might
want to break up StdLibExtras.h into multiple headers if it’s hurting build

More information about the webkit-reviews mailing list