[webkit-reviews] review granted: [Bug 231755] [iOS] Paint <datalist> indicator in RenderTheme : [Attachment 441255] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 14 12:32:56 PDT 2021


Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 231755: [iOS] Paint <datalist> indicator in RenderTheme
https://bugs.webkit.org/show_bug.cgi?id=231755

Attachment 441255: Patch

https://bugs.webkit.org/attachment.cgi?id=441255&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 441255
  --> https://bugs.webkit.org/attachment.cgi?id=441255
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441255&action=review

> Source/WebCore/rendering/style/RenderStyle.h:1477
> +    void setHasExplicitlyClearedContent(bool v) {
m_nonInheritedFlags.hasExplicitlyClearedContent = v; }

`v` is not my favorite name for a parameter


More information about the webkit-reviews mailing list