[webkit-reviews] review granted: [Bug 231251] Add back RetainPtrARC and TypeCastsCocoaARC tests to TestWTF : [Attachment 440455] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 231251: Add back RetainPtrARC and TypeCastsCocoaARC tests to TestWTF
https://bugs.webkit.org/show_bug.cgi?id=231251

Attachment 440455: Patch v1

https://bugs.webkit.org/attachment.cgi?id=440455&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 440455
  --> https://bugs.webkit.org/attachment.cgi?id=440455
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=440455&action=review

Nice solution.

> Source/WTF/ChangeLog:12
> +	   * wtf/cocoa/TypeCastsCocoa.h:
> +	   (checked_objc_castArc):
> +	   - Change `checked_objc_castARC` to `checked_objc_castArc` to
> +	     match `adoptNSArc`.

Nice to match, but not sure why Chris decided to turn ARC into a word.

> Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:38
> +#define TEST_WTF_BEGIN_AUTORELEASEPOOL @autoreleasepool {

I suggest a name like: BEGIN_AUTORELEASEPOOL_FOR_ARC_DEBUG

I understand the concept of using "WTF" to avoid conflicts, and "TEST", but I
don’t think either are needed in practice.