[webkit-reviews] review granted: [Bug 231344] [iOS] Get rid of the deviceClass function, up-leveling to deviceClassIsSmallScreen : [Attachment 440459] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 6 18:25:07 PDT 2021


Tim Horton <thorton at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 231344: [iOS] Get rid of the deviceClass function, up-leveling to
deviceClassIsSmallScreen
https://bugs.webkit.org/show_bug.cgi?id=231344

Attachment 440459: Patch

https://bugs.webkit.org/attachment.cgi?id=440459&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 440459
  --> https://bugs.webkit.org/attachment.cgi?id=440459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440459&action=review

Love it! I'm still trying to puzzle out `deviceHasIPadCapability` with folks.

> Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm:72
>  #if PLATFORM(MACCATALYST)
>      return true;
>  #elif PLATFORM(IOS)

Probably (?) could get rid of this ifdef

> Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:278
>  #if PLATFORM(MACCATALYST)
>      return true;

And again


More information about the webkit-reviews mailing list