[webkit-reviews] review granted: [Bug 233379] Structures should be allocated out of an aligned pool of memory so StructureID->Structure* is fast. : [Attachment 444986] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 233379: Structures should be allocated out of an aligned pool of memory so
StructureID->Structure* is fast.
https://bugs.webkit.org/show_bug.cgi?id=233379

Attachment 444986: Patch

https://bugs.webkit.org/attachment.cgi?id=444986&action=review




--- Comment #6 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 444986
  --> https://bugs.webkit.org/attachment.cgi?id=444986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444986&action=review

r=me with 32bit and WIndows fixes.
And please monitor performance / schedule A-B test of (Speedometer2,
JetStream2) / memory change after landing to ensure that this does not cause
the regression.

> Source/JavaScriptCore/heap/StructureAllignedMemoryAllocator.h:1
> +/*

This file is duplicate to Struc tureAlignedMemoryAllocator.h
This is mis-typed "Alligned".