[webkit-reviews] review granted: [Bug 232652] [JSC] Clean up StructureStubInfo initialization : [Attachment 443164] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 2 19:47:55 PDT 2021


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 232652: [JSC] Clean up StructureStubInfo initialization
https://bugs.webkit.org/show_bug.cgi?id=232652

Attachment 443164: Patch

https://bugs.webkit.org/attachment.cgi?id=443164&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 443164
  --> https://bugs.webkit.org/attachment.cgi?id=443164
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443164&action=review

> Source/WTF/wtf/FixedVector.h:68
> +	   : m_storage(std::forward<Container>(other))

Why forward?

> Source/WTF/wtf/FixedVector.h:74
> +	   m_storage = std::forward<Container>(other);

Why forward?


More information about the webkit-reviews mailing list