[webkit-reviews] review denied: [Bug 186344] font-synthesis inline/computed style in non-canonical : [Attachment 443153] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 2 20:04:30 PDT 2021
Simon Fraser (smfr) <simon.fraser at apple.com> has denied review:
Bug 186344: font-synthesis inline/computed style in non-canonical
https://bugs.webkit.org/show_bug.cgi?id=186344
Attachment 443153: Patch
https://bugs.webkit.org/attachment.cgi?id=443153&action=review
--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 443153
--> https://bugs.webkit.org/attachment.cgi?id=443153
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=443153&action=review
>> Source/WebCore/css/StyleProperties.cpp:173
>> + return fontSynthesisPropertyValue(*value);
>
> This is a surprising place for this code. Why is this here and not below (or
maybe even in another function?)
Falling through from CSSPropertyStrokeOpacity and returning a
fontSynthesisPropertyValue() doesn't seem right.
More information about the webkit-reviews
mailing list