[webkit-reviews] review granted: [Bug 232603] Terminate unresponsive network process by crashing it : [Attachment 443109] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 232603: Terminate unresponsive network process by crashing it
https://bugs.webkit.org/show_bug.cgi?id=232603

Attachment 443109: Patch

https://bugs.webkit.org/attachment.cgi?id=443109&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 443109
  --> https://bugs.webkit.org/attachment.cgi?id=443109
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443109&action=review

r=me with comment.

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:153
> +    if (shouldTerminateNetworkProcessBySendingMessage()) {

Please add a comment to explain that we're doing this to generate a crash
report when the network process is killed for being unresponsive several times
in a row. It is other not clear why sometimes we're killing by sending an IPC
and sometimes not.