[webkit-reviews] review granted: [Bug 232623] [cmake] Check "cortex" string in the CMAKE_SYSTEM_PROCESSOR for defining WTF_CPU_* vars : [Attachment 443092] patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 232623: [cmake] Check "cortex" string in the CMAKE_SYSTEM_PROCESSOR for
defining WTF_CPU_* vars
https://bugs.webkit.org/show_bug.cgi?id=232623

Attachment 443092: patch

https://bugs.webkit.org/attachment.cgi?id=443092&action=review




--- Comment #3 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 443092
  --> https://bugs.webkit.org/attachment.cgi?id=443092
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443092&action=review

> Source/cmake/WebKitCommon.cmake:89
> +    if (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES
"(^aarch64|^arm64|^cortex-?[am][2-7][2-7])")

Maybe is better to use "cortex-?[am][2-7][2-8]" so it matches also Cortex-A78:
https://en.wikipedia.org/wiki/ARM_Cortex-A#External_links