[webkit-reviews] review granted: [Bug 226180] Allow CTI stubs to be generated off the main thread : [Attachment 429554] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 226180: Allow CTI stubs to be generated off the main thread
https://bugs.webkit.org/show_bug.cgi?id=226180

Attachment 429554: patch

https://bugs.webkit.org/attachment.cgi?id=429554&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 429554
  --> https://bugs.webkit.org/attachment.cgi?id=429554
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429554&action=review

r=me

> Source/JavaScriptCore/jit/JITThunks.cpp:138
> +	   if (entry.needsCrossModifyingCodeFence && !isCompilationThread()) {

Can you add a comment here as to why compilation threads don't need the
crossModifyingCodeFence?  It isn't obvious from reading this section of code.