[webkit-reviews] review granted: [Bug 226184] Remove deprecated API usage in PageClientImplMac : [Attachment 429561] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Dana Estra <destra at apple.com>'s
request for review:
Bug 226184: Remove deprecated API usage in PageClientImplMac
https://bugs.webkit.org/show_bug.cgi?id=226184

Attachment 429561: Patch

https://bugs.webkit.org/attachment.cgi?id=429561&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 429561
  --> https://bugs.webkit.org/attachment.cgi?id=429561
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429561&action=review

r=me, nice!

> Source/WebKit/UIProcess/mac/PageClientImplMac.mm:447
> +    NSPoint windowCoord = [[m_view window] convertPointFromScreen:point];

NIT: I think you can `m_view.window` :)

> Source/WebKit/UIProcess/mac/PageClientImplMac.mm:455
> +    tempRect.origin = [[m_view window]
convertPointToScreen:tempRect.origin];

ditto (:447)