[webkit-reviews] review granted: [Bug 226152] Use CheckedLock in even more places : [Attachment 429455] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226152: Use CheckedLock in even more places
https://bugs.webkit.org/show_bug.cgi?id=226152

Attachment 429455: Patch

https://bugs.webkit.org/attachment.cgi?id=429455&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 429455
  --> https://bugs.webkit.org/attachment.cgi?id=429455
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429455&action=review

>
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
373
> +// FIXME: This modifies m_data without grabbing m_dataLock.

Hard to fix?

> Source/WebCore/worklets/PaintWorkletGlobalScope.h:68
> +    HashMap<String, std::unique_ptr<PaintDefinition>>& paintDefinitionMap()
WTF_REQUIRES_LOCK(m_paintDefinitionLock)
> +    {
> +	   ASSERT(m_paintDefinitionLock.isLocked());
> +	   return m_paintDefinitionMap;
> +    }

Can we put this function body after the class definition to keep the class
definition easy to read?