[webkit-reviews] review granted: [Bug 226145] Drop WTF::tryHoldLock() as it is incompatible with Clang Thread Safety Analysis : [Attachment 429449] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 23 12:44:36 PDT 2021
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226145: Drop WTF::tryHoldLock() as it is incompatible with Clang Thread
Safety Analysis
https://bugs.webkit.org/show_bug.cgi?id=226145
Attachment 429449: Patch
https://bugs.webkit.org/attachment.cgi?id=429449&action=review
--- Comment #16 from Darin Adler <darin at apple.com> ---
Comment on attachment 429449
--> https://bugs.webkit.org/attachment.cgi?id=429449
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=429449&action=review
> Source/WTF/wtf/Locker.h:59
> +constexpr AdoptLockTag AdoptLock = AdoptLockTag();
I am surprised that we need the "= AdoptLockTag()" here. Can we omit it?
More information about the webkit-reviews
mailing list