[webkit-reviews] review granted: [Bug 222277] [ macOS Wk2 ] media/media-fragments/TC0051.html is flakey crashing : [Attachment 428461] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 13 08:45:58 PDT 2021

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 222277: [ macOS Wk2 ] media/media-fragments/TC0051.html is flakey crashing

Attachment 428461: Patch


--- Comment #27 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 428461
  --> https://bugs.webkit.org/attachment.cgi?id=428461

View in context: https://bugs.webkit.org/attachment.cgi?id=428461&action=review

> +	   m_avAsset = adoptNS([PAL::allocAVURLAssetInstance()
initWithURL:cocoaURL options:options.get()]);

It is probably worth restructuring this so you can wrap the second allocation
attempt in another @try/@catch so we don't crash if it throws another exception
for some reason.

More information about the webkit-reviews mailing list