[webkit-reviews] review denied: [Bug 225739] Delete WebSQL code from WebKit2 : [Attachment 428478] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 13 08:49:48 PDT 2021

Sihui Liu <sihui_liu at apple.com> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 225739: Delete WebSQL code from WebKit2

Attachment 428478: Patch


--- Comment #2 from Sihui Liu <sihui_liu at apple.com> ---
Comment on attachment 428478
  --> https://bugs.webkit.org/attachment.cgi?id=428478

View in context: https://bugs.webkit.org/attachment.cgi?id=428478&action=review

> Source/WebKit/ChangeLog:17
> +	   (WebKit::m_messagePortChannelRegistry): Deleted.


> Source/WebKit/ChangeLog:26
> +	   * Shared/WebSQLiteDatabaseTracker.cpp: Removed.
> +	   * Shared/WebSQLiteDatabaseTracker.h: Removed.

Despite its name, WebSQLiteDatabaseTracker is actually responsible for
monitoring all SQLite operations (network process uses it to notify UI process
to not suspend it during database operations, see SQLiteDatabaseTracker), so
this seems wrong.

> Source/WebKit/ChangeLog:42
> +	   (WebKit::m_lastNavigationWasAppBound):

I didn't see related change in this patch.

More information about the webkit-reviews mailing list