[webkit-reviews] review denied: [Bug 225739] Delete WebSQL code from WebKit2 : [Attachment 428478] Patch

[bugzilla-daemon at webkit.org]

Sihui Liu <sihui_liu at apple.com> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 225739: Delete WebSQL code from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=225739

Attachment 428478: Patch

https://bugs.webkit.org/attachment.cgi?id=428478&action=review




--- Comment #2 from Sihui Liu <sihui_liu at apple.com> ---
Comment on attachment 428478
  --> https://bugs.webkit.org/attachment.cgi?id=428478
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428478&action=review

> Source/WebKit/ChangeLog:17
> +	   (WebKit::m_messagePortChannelRegistry): Deleted.

Deleted?

> Source/WebKit/ChangeLog:26
> +	   * Shared/WebSQLiteDatabaseTracker.cpp: Removed.
> +	   * Shared/WebSQLiteDatabaseTracker.h: Removed.

Despite its name, WebSQLiteDatabaseTracker is actually responsible for
monitoring all SQLite operations (network process uses it to notify UI process
to not suspend it during database operations, see SQLiteDatabaseTracker), so
this seems wrong.

> Source/WebKit/ChangeLog:42
> +	   (WebKit::m_lastNavigationWasAppBound):

I didn't see related change in this patch.