[webkit-reviews] review granted: [Bug 225493] css-display-none actions from WKContentRuleList should apply to pages loaded with loadData and loadHTMLString : [Attachment 427952] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 225493: css-display-none actions from WKContentRuleList should apply to
pages loaded with loadData and loadHTMLString
https://bugs.webkit.org/show_bug.cgi?id=225493

Attachment 427952: Patch

https://bugs.webkit.org/attachment.cgi?id=427952&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 427952
  --> https://bugs.webkit.org/attachment.cgi?id=427952
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427952&action=review

> Source/WebCore/loader/DocumentLoader.cpp:528
> +	   // We want the CSS but not the blocking or upgrading for substitute
data.

Based on your change log comment I would write something more like: "We want
the CSS to be loaded for us, but we ignore any attempt to block or upgrade the
connection since there is no connection."

Not sure my sentence was accurate, but I think it’s easier to understand than
"[don’t want] the blocking or upgrading" and instead of saying "for substitute
data" which is already said by the name of the function we are in, we can point
out *why* we ignore attempts to block or upgrade.