[webkit-reviews] review granted: [Bug 225557] Factor out find bounce layer : [Attachment 428110] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 8 21:38:42 PDT 2021
Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 225557: Factor out find bounce layer
https://bugs.webkit.org/show_bug.cgi?id=225557
Attachment 428110: Patch
https://bugs.webkit.org/attachment.cgi?id=428110&action=review
--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 428110
--> https://bugs.webkit.org/attachment.cgi?id=428110
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=428110&action=review
> Source/WebCore/ChangeLog:3
> + Factor out find bounce layer
This really undersells the change. It's not just "factor it out" but really
"reimplement it in terms of CALayer to make it cross-platform"
> Source/WebCore/ChangeLog:9
> + compatable with iOS.
sp: Compatible
> Source/WebCore/ChangeLog:11
> + No behavior change.
Please make sure you test find in both modern WebKit and WebKitLegacy, since
there are precisely 0 automated tests for TextIndicatorWindow+friends.
> Source/WebCore/page/cocoa/WebTextIndicatorLayer.mm:163
> +
Weird extraneous newline
> Source/WebCore/page/cocoa/WebTextIndicatorLayer.mm:165
> + RetainPtr<CGColorRef> rimShadowColor
=adoptCF(CGColorCreateGenericGray(0, 0.35));
Missing a space after the =
> Source/WebCore/page/mac/TextIndicatorWindow.mm:119
> + [m_textIndicatorView setWantsLayer:YES];
> + [m_textIndicatorView setLayer:m_textIndicatorLayer.get()];
IIRC the order of these is important. The documentation says that you want them
in the opposite order to make a layer-hosting view, which I think is the mode
you want? Take a gander at the discussion section in
https://developer.apple.com/documentation/appkit/nsview/1483695-wantslayer?lang
uage=objc
More information about the webkit-reviews
mailing list