[webkit-reviews] review granted: [Bug 223762] [ macOS wk2 ] media/pip-video-going-into-fullscreen.html is a flakey timeout : [Attachment 424805] Rebase the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 31 13:00:22 PDT 2021
Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 223762: [ macOS wk2 ] media/pip-video-going-into-fullscreen.html is a
flakey timeout
https://bugs.webkit.org/show_bug.cgi?id=223762
Attachment 424805: Rebase the patch
https://bugs.webkit.org/attachment.cgi?id=424805&action=review
--- Comment #9 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 424805
--> https://bugs.webkit.org/attachment.cgi?id=424805
Rebase the patch
View in context: https://bugs.webkit.org/attachment.cgi?id=424805&action=review
> LayoutTests/media/pip-video-going-into-fullscreen.html:44
> + video.addEventListener('webkitfullscreenchange',
onbeginfullscreen);
Nit: you use `video.addEventListener('webkitfullscreenchange',
onbeginfullscreen, {once: true})` you won't have to remove the listener below.
More information about the webkit-reviews
mailing list