[webkit-reviews] review granted: [Bug 223817] [GPU process] Enable CFPrefs direct mode : [Attachment 424401] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 31 12:55:26 PDT 2021


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 223817: [GPU process] Enable CFPrefs direct mode
https://bugs.webkit.org/show_bug.cgi?id=223817

Attachment 424401: Patch

https://bugs.webkit.org/attachment.cgi?id=424401&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 424401
  --> https://bugs.webkit.org/attachment.cgi?id=424401
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424401&action=review

R=me

> Source/WebKit/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=223817

Radar, please.

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:579
> +(allow file-read*

Please add Literal “/Library/Preferences/.GlobalOreferences.plist”, too.

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:580
> +    (home-subpath "/Library/Preferences/.GlobalPreferences.plist")

Please add .GlobalPreferences_m.plist’ too.


More information about the webkit-reviews mailing list