[webkit-reviews] review granted: [Bug 223707] [GPUP] Add an IPC message to implement RemoteImageDecoderAVF::clearFrameBufferCache() : [Attachment 424575] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 223707: [GPUP] Add an IPC message to implement
RemoteImageDecoderAVF::clearFrameBufferCache()
https://bugs.webkit.org/show_bug.cgi?id=223707

Attachment 424575: Patch

https://bugs.webkit.org/attachment.cgi?id=424575&action=review




--- Comment #12 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 424575
  --> https://bugs.webkit.org/attachment.cgi?id=424575
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424575&action=review

> Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp:142
> +	   imageDecoder->clearFrameBufferCache(index);

Could be a one-liner. ImageDecoderAVFObjC::clearFrameBufferCache implementation
seems safe even if index is above frameCount.

> Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVF.cpp:231
> +    for (size_t i = 0; i <= index; i++)

Could be a one liner, we also tend to prefer < instead of <=, and ++I as well.
for (size_t i = 0; i < std::min(index + 1, m_frameCount); ++i)