[webkit-reviews] review granted: [Bug 222277] [ macOS Wk2 ] media/media-fragments/TC0051.html is flakey crashing : [Attachment 424551] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 222277: [ macOS Wk2 ] media/media-fragments/TC0051.html is flakey crashing
https://bugs.webkit.org/show_bug.cgi?id=222277

Attachment 424551: Patch

https://bugs.webkit.org/attachment.cgi?id=424551&action=review




--- Comment #21 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 424551
  --> https://bugs.webkit.org/attachment.cgi?id=424551
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424551&action=review

> Source/WebCore/ChangeLog:14
> +	   r274734 attempted to be efficient, by only checking whether calls to
parse a malforgmed fragment

Very minor, no change needed. Malforgmed is misspelled.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:814
> +    NeverDestroyed<Optional<bool>> value;

This should be static.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:995
> +	   m_avAsset = adoptNS([PAL::allocAVURLAssetInstance()
initWithURL:cocoaURL options:options.get()]);

Could this throw an exception?