[webkit-reviews] review granted: [Bug 223694] Address undefined behavior found by UBSan in StringToIntegerConversion.h : [Attachment 424142] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 223694: Address undefined behavior found by UBSan in
StringToIntegerConversion.h
https://bugs.webkit.org/show_bug.cgi?id=223694

Attachment 424142: Patch

https://bugs.webkit.org/attachment.cgi?id=424142&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 424142
  --> https://bugs.webkit.org/attachment.cgi?id=424142
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424142&action=review

r=me

> Source/WTF/wtf/text/StringToIntegerConversion.h:54
> +    Checked<IntegralType, RecordOverflow> value = 0;

No need for = 0 anymore here.