[webkit-reviews] review granted: [Bug 223541] [LayoutTests] Convert http/tests/resourceLoadStatistics convert PHP to Python : [Attachment 424134] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 12:07:58 PDT 2021


Jonathan Bedard <jbedard at apple.com> has granted Chris Gambrell
<cgambrell at apple.com>'s request for review:
Bug 223541: [LayoutTests] Convert http/tests/resourceLoadStatistics convert PHP
to Python
https://bugs.webkit.org/show_bug.cgi?id=223541

Attachment 424134: Patch

https://bugs.webkit.org/attachment.cgi?id=424134&action=review




--- Comment #9 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 424134
  --> https://bugs.webkit.org/attachment.cgi?id=424134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424134&action=review

>
LayoutTests/http/tests/resourceLoadStatistics/resources/set-cookie-on-redirect.
py:47
> +    )

Should add an "else" that writes \r\n to stdout so that if something breaks our
assumptions here we will still have a valid response

> LayoutTests/http/tests/resourceLoadStatistics/resources/set-cookie.py:16
> +    'Set-Cookie: {}={}; expires={} GMT; Max-Age=2592000; path=/\r\n'

Have enough in here that I think naming your string arguments would be helpful.


More information about the webkit-reviews mailing list