[webkit-reviews] review granted: [Bug 223635] Implement cachedPropertyValue for WebXR [SameObject] attributes : [Attachment 424025] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 15:27:57 PDT 2021

Chris Dumez <cdumez at apple.com> has granted Imanol Fernandez
<ifernandez at igalia.com>'s request for review:
Bug 223635: Implement cachedPropertyValue for WebXR [SameObject] attributes

Attachment 424025: Patch


--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 424025
  --> https://bugs.webkit.org/attachment.cgi?id=424025

View in context: https://bugs.webkit.org/attachment.cgi?id=424025&action=review

> Source/WebCore/Modules/webxr/WebXRViewerPose.idl:36
> +    [CustomGetter, SameObject] readonly attribute FrozenArray<WebXRView>

I suggest you try [CachedAttribute, SameObject] for this FrozenArray, as Sam
suggested. If it works, then you won't need custom bindings for this one, which
would be nice.

More information about the webkit-reviews mailing list