[webkit-reviews] review granted: [Bug 223635] Implement cachedPropertyValue for WebXR [SameObject] attributes : [Attachment 424025] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Imanol Fernandez
<ifernandez at igalia.com>'s request for review:
Bug 223635: Implement cachedPropertyValue for WebXR [SameObject] attributes
https://bugs.webkit.org/show_bug.cgi?id=223635

Attachment 424025: Patch

https://bugs.webkit.org/attachment.cgi?id=424025&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 424025
  --> https://bugs.webkit.org/attachment.cgi?id=424025
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424025&action=review

> Source/WebCore/Modules/webxr/WebXRViewerPose.idl:36
> +    [CustomGetter, SameObject] readonly attribute FrozenArray<WebXRView>
views;

I suggest you try [CachedAttribute, SameObject] for this FrozenArray, as Sam
suggested. If it works, then you won't need custom bindings for this one, which
would be nice.