[webkit-reviews] review granted: [Bug 157101] All Books quirks are flakily not applied in modern WebKit (Add a preference to allow clients to turn on the "const" JS quirk) : [Attachment 424073] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 157101: All Books quirks are flakily not applied in modern WebKit (Add a
preference to allow clients to turn on the "const" JS quirk)
https://bugs.webkit.org/show_bug.cgi?id=157101

Attachment 424073: Patch

https://bugs.webkit.org/attachment.cgi?id=424073&action=review




--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 424073
  --> https://bugs.webkit.org/attachment.cgi?id=424073
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424073&action=review

> Source/WebKit/ChangeLog:28
> +	   Add an assertion, and move the quirk to live as a setting on the
process
> +	   pool configuration, to be set via SPI by Books, instead of as a
bundle check.

I know we have long wanted to use SPI or API for this quirk rather than a
bundle ID check. I would slightly prefer API over SPI. Is this OK for iBooks?
Do we need a bundle ID check to smooth over a transition period? If so, can we
make one that works?

> Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm:212
> +    xpc_dictionary_set_string(bootstrapMessage.get(), "client-sdk-version",
String::number(applicationSDKVersion()).utf8().data());
>      xpc_dictionary_set_string(bootstrapMessage.get(), "process-identifier",
String::number(m_launchOptions.processIdentifier.toUInt64()).utf8().data());

Seems like we ought to make a CString::number function for cases like this.