[webkit-reviews] review granted: [Bug 223380] Regression(r273542) Degraded ScriptProcessorNode performance/quality for (14.0.3+ and iOS 14.4.1+) : [Attachment 423503] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 223380: Regression(r273542) Degraded ScriptProcessorNode
performance/quality for (14.0.3+ and iOS 14.4.1+)
https://bugs.webkit.org/show_bug.cgi?id=223380

Attachment 423503: Patch

https://bugs.webkit.org/attachment.cgi?id=423503&action=review




--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 423503
  --> https://bugs.webkit.org/attachment.cgi?id=423503
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423503&action=review

r=me

I really like this.

> Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:132
> +    for (unsigned i = 0; i < bufferCount; ++i) {
> +	   auto locker = holdLock(m_bufferLocks[i]);
> +	   m_inputBuffers[i] = nullptr;
> +	   m_outputBuffers[i] = nullptr;
> +    }

Nice!