[webkit-reviews] review granted: [Bug 223303] [iOS][FCR] Use system colors for the new appearance : [Attachment 423490] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 223303: [iOS][FCR] Use system colors for the new appearance
https://bugs.webkit.org/show_bug.cgi?id=223303

Attachment 423490: Patch

https://bugs.webkit.org/attachment.cgi?id=423490&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 423490
  --> https://bugs.webkit.org/attachment.cgi?id=423490
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423490&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1456
> +    if (cssValueID == CSSValueAppleSystemSecondaryFillDisabled)
> +	   return systemColor(CSSValueAppleSystemSecondaryFill,
options).colorWithAlphaMultipliedBy(0.75f);

Why are we synthesizing not-real semantic colors instead of just doing it in
content?

> Source/WebCore/rendering/RenderThemeIOS.mm:2159
> +	   // The inner circle is 1 / 3 the size of the surrounding circle,
> +	   // leaving 2 / 3 around it. (2 / 3) / 2 = 1 / 3.
> +	   constexpr float innerInverseRatio = 1 / 3.0f;

What's this got to do with system colors?