[webkit-reviews] review granted: [Bug 222965] Make RTCDataChannel transferable : [Attachment 422914] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 222965: Make RTCDataChannel transferable
https://bugs.webkit.org/show_bug.cgi?id=222965

Attachment 422914: Patch

https://bugs.webkit.org/attachment.cgi?id=422914&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 422914
  --> https://bugs.webkit.org/attachment.cgi?id=422914
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422914&action=review

> Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:68
> +	   if (!channel->m_handler)
> +	       return;

Is this unexpected? If so, it may be worth logging an error to help track down
errors later.

> Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:270
> +    ASSERT(m_isDetachable);

Maybe ASSERT(canDetach())?

> Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:295
> +    if (identifier.processIdentifier != Process::identifier()) {
> +	   // FIXME: Add support for out-of-process data channels.
> +	   return createClosedChannel(context, WTFMove(label),
WTFMove(options));
> +    }

Maybe log an error here to help diagnose error reports?

> Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:301
> +    if (!handler)
> +	   return createClosedChannel(context, WTFMove(label),
WTFMove(options));

Ditto