[webkit-reviews] review granted: [Bug 222982] Update RTCRtpScriptTransform to the latest version of the spec : [Attachment 422821] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 222982: Update RTCRtpScriptTransform to the latest version of the spec
https://bugs.webkit.org/show_bug.cgi?id=222982

Attachment 422821: Patch

https://bugs.webkit.org/attachment.cgi?id=422821&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 422821
  --> https://bugs.webkit.org/attachment.cgi?id=422821
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422821&action=review

> Source/WebCore/ChangeLog:10
> +	   Add support for options parameter provided in RTCRtpScriptTrtansform
constructor.

s/RTCRtpScriptTrtansform/RTCRtpScriptTransform/

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:55
> +    auto transformer = adoptRef(*new RTCRtpScriptTransformer(context,
WTFMove(options), WTFMove(port), readable.releaseReturnValue(),
WTFMove(readableSource)));

Is there any reason to not have the constructor get the
SimpleReadableStreamSource from the ReadableStream?

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:104
> +	       return writable;

I thought this was wrong at first because of the variable name, something like
`writableOrException` might make it clearer.