[webkit-reviews] review granted: [Bug 223016] Release assertion failures under Editor::scanSelectionForTelephoneNumbers : [Attachment 422802] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 223016: Release assertion failures under
Editor::scanSelectionForTelephoneNumbers
https://bugs.webkit.org/show_bug.cgi?id=223016

Attachment 422802: Patch

https://bugs.webkit.org/attachment.cgi?id=422802&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 422802
  --> https://bugs.webkit.org/attachment.cgi?id=422802
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422802&action=review

> Source/WebCore/editing/Editor.cpp:3705
> +	   if (selectedRange) {

Why not put selectedRange inside here?

> Source/WebCore/editing/Editor.cpp:3710
> +	       extendedRange = extendSelection(*selectedRange,
charactersToExtend);
> +	   }
> +	   
> +	   if (extendedRange) {

Can't we just nest these if's?