[webkit-reviews] review granted: [Bug 222846] git-webkit should have an "info" command : [Attachment 422740] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 9 22:46:51 PST 2021


Ryosuke Niwa <rniwa at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 222846: git-webkit should have an "info" command
https://bugs.webkit.org/show_bug.cgi?id=222846

Attachment 422740: Patch

https://bugs.webkit.org/attachment.cgi?id=422740&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 422740
  --> https://bugs.webkit.org/attachment.cgi?id=422740
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422740&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:34
> +class Info(Command):
> +    name = 'info'
> +    help = 'Print information about the HEAD commit'

This seems a bit backwards? Why not define info in terms of find instead?


More information about the webkit-reviews mailing list