[webkit-reviews] review granted: [Bug 222565] Web Inspector: Grid overlay does not adjust for element transforms (rotation, scale, etc.) : [Attachment 422342] Patch v2.0 - Use renderGrid to transform points

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 222565: Web Inspector: Grid overlay does not adjust for element transforms
(rotation, scale, etc.)
https://bugs.webkit.org/show_bug.cgi?id=222565

Attachment 422342: Patch v2.0 - Use renderGrid to transform points

https://bugs.webkit.org/attachment.cgi?id=422342&action=review




--- Comment #12 from BJ Burg <bburg at apple.com> ---
Comment on attachment 422342
  --> https://bugs.webkit.org/attachment.cgi?id=422342
Patch v2.0 - Use renderGrid to transform points

View in context: https://bugs.webkit.org/attachment.cgi?id=422342&action=review

r=me

Please test this with a grid inside an iframe. File a followup or new patch
revision if localToContainer is not enough-it may require localToRoot.

> Source/WebCore/inspector/InspectorOverlay.cpp:1183
> +	   for (float y = -topSide.length(); y < leftSide.length(); y +=
hatchSpacing) {

This is way easier to grok than the scrollOffset version.

> Source/WebCore/inspector/InspectorOverlay.cpp:1456
> +	       auto extendedLine =
columnStartLine.extendedToBounds(viewportBounds);

Very nice.

> Source/WebCore/inspector/InspectorOverlay.cpp:1614
> +	       // If any two lines are coincident with each other, they will
not have an intersection, which can occur with extreme `transform:
perspective(...)` values.

Wow!