[webkit-reviews] review granted: [Bug 221727] [CMake] Bump cmake_minimum_required version to 3.12 or later : [Attachment 422376] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 5 10:39:11 PST 2021
Konstantin Tokarev <annulen at yandex.ru> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 221727: [CMake] Bump cmake_minimum_required version to 3.12 or later
https://bugs.webkit.org/show_bug.cgi?id=221727
Attachment 422376: Patch
https://bugs.webkit.org/attachment.cgi?id=422376&action=review
--- Comment #9 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 422376
--> https://bugs.webkit.org/attachment.cgi?id=422376
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=422376&action=review
>> CMakeLists.txt:13
>> +cmake_minimum_required(VERSION 3.12)
>
> Added a note here about that annulen
Great idea, similar mistakes were made in the past too
More information about the webkit-reviews
mailing list