[webkit-reviews] review granted: [Bug 227279] Add ID and versioning support for AppHighlights : [Attachment 432438] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 227279: Add ID and versioning support for AppHighlights
https://bugs.webkit.org/show_bug.cgi?id=227279

Attachment 432438: Patch

https://bugs.webkit.org/attachment.cgi?id=432438&action=review




--- Comment #13 from Tim Horton <thorton at apple.com> ---
Comment on attachment 432438
  --> https://bugs.webkit.org/attachment.cgi?id=432438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432438&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm:128
> +// Ensure that future versions of the blog format can add additional data
and still be decoded successfully by version of WebKit that only know about the
current format.

"blog"?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm:145
> +// Ensure that we don't block against later versions with an explicite
version check.

"explicite"?

I would say something more like "Older versions of WebKit need to be able to
decode blobs encoded on newer versions of WebKit, so ensure that <blah blah>"