[webkit-reviews] review granted: [Bug 227414] I-beam pointer is vertical for vertical text : [Attachment 432315] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 227414: I-beam pointer is vertical for vertical text
https://bugs.webkit.org/show_bug.cgi?id=227414

Attachment 432315: Patch

https://bugs.webkit.org/attachment.cgi?id=432315&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 432315
  --> https://bugs.webkit.org/attachment.cgi?id=432315
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432315&action=review

>>>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3038
>>>>	  info.lineCaretExtent = view->contentsToRootView(lineRect);
>>> 
>>> Does this rectangle maybe need adjusting as well? The fact that we
explicitly set lineRect's width but never height seems ... fishy.
>> 
>> I filed rdar://77564647, Alan offered to investigate the misaligned region
returned in pointerRegionForPositionInformation. Maybe we can land this piece
now, though.
> 
> Edit: I filed rdar://79887141.

Yeah, as long as this doesn't make it any worse, I'm on board.