[webkit-reviews] review granted: [Bug 228289] Implement IDBTransaction.durability : [Attachment 434455] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 28 14:42:39 PDT 2021


Darin Adler <darin at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 228289: Implement IDBTransaction.durability
https://bugs.webkit.org/show_bug.cgi?id=228289

Attachment 434455: Patch

https://bugs.webkit.org/attachment.cgi?id=434455&action=review




--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 434455
  --> https://bugs.webkit.org/attachment.cgi?id=434455
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434455&action=review

> Source/WebCore/platform/sql/SQLiteDatabase.h:100
> +    enum class CheckpointMode : uint8_t { Passive, Full, Restart, Truncate
};

Since WebKit is only using Full and Truncate, can we leave Passive and Restart
out for now? We can add then if we find we need the modes.


More information about the webkit-reviews mailing list