[webkit-reviews] review granted: [Bug 228564] [macOS Catalina] Some feature preferences have wrong default values : [Attachment 434465] Revise the patch based on Tim's comment

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 228564: [macOS Catalina] Some feature preferences have wrong default values
https://bugs.webkit.org/show_bug.cgi?id=228564

Attachment 434465: Revise the patch based on Tim's comment

https://bugs.webkit.org/attachment.cgi?id=434465&action=review




--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 434465
  --> https://bugs.webkit.org/attachment.cgi?id=434465
Revise the patch based on Tim's comment

View in context: https://bugs.webkit.org/attachment.cgi?id=434465&action=review

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:295
> +#if PLATFORM(MAC)
> +    return true;
> +#else
>      return false;
> +#endif

Technically by the same logic you could just change these to return true
instead of the PLATFORM(MAC), because we'll always have SYSTEM_FEATURE_FLAGS on
iOS-family). But either way will behave the same.