[webkit-reviews] review granted: [Bug 228106] [GStreamer] Switch raw GstStructure pointers to GUniquePtr : [Attachment 433872] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 20 07:34:32 PDT 2021


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 228106: [GStreamer] Switch raw GstStructure pointers to GUniquePtr
https://bugs.webkit.org/show_bug.cgi?id=228106

Attachment 433872: Patch

https://bugs.webkit.org/attachment.cgi?id=433872&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 433872
  --> https://bugs.webkit.org/attachment.cgi?id=433872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433872&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2399
> +	   m_mediaLocationCurrentIndex =
static_cast<int>(gst_value_list_get_size(locations)) -1;

Now that we're changing this line, let's fix that - 1 .


More information about the webkit-reviews mailing list