[webkit-reviews] review granted: [Bug 228097] Characters with no fonts that support them are drawn as two .notdef glyphs in the fast text codepath : [Attachment 433849] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Myles C. Maxfield <mmaxfield at apple.com>'s
request for review:
Bug 228097: Characters with no fonts that support them are drawn as two .notdef
glyphs in the fast text codepath
https://bugs.webkit.org/show_bug.cgi?id=228097

Attachment 433849: Patch

https://bugs.webkit.org/attachment.cgi?id=433849&action=review




--- Comment #8 from zalan <zalan at apple.com> ---
Comment on attachment 433849
  --> https://bugs.webkit.org/attachment.cgi?id=433849
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433849&action=review

> Source/WebCore/platform/graphics/WidthIterator.cpp:115
> +	       if (!glyphBuffer.glyphAt(i) && !glyphBuffer.glyphAt(i + 1)) {

I assume these surrogates come in pairs and the i + 1 derefs are safe.