[webkit-reviews] review granted: [Bug 227795] >4K Referer should have tailing / : [Attachment 433431] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 227795: >4K Referer should have tailing /
https://bugs.webkit.org/show_bug.cgi?id=227795

Attachment 433431: Patch

https://bugs.webkit.org/attachment.cgi?id=433431&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 433431
  --> https://bugs.webkit.org/attachment.cgi?id=433431
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433431&action=review

r=me assuming the bots are happy.

>>> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:79
>>> +	 checkReferer([NSURL URLWithString:longPath], "http://webkit.org/");
>> 
>> It is a bit confusing because this referrer is not > 4K.
>> 
>> Also, it seems like this should be easily writable as a layout test?
> 
> This is the trimmed referrer.

Oh, I get it now.

I would have liked if we had a layout test for this (as we can run in other
browsers and other ports of WebKit). But technically, you have test coverage so
r+.