[webkit-reviews] review granted: [Bug 227510] Add a new Air::Arg kind ZeroReg to let AIR recognise the new instructions/forms accepting zero register in ARM64 : [Attachment 433427] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 227510: Add a new Air::Arg kind ZeroReg to let AIR recognise the new
instructions/forms accepting zero register in ARM64
https://bugs.webkit.org/show_bug.cgi?id=227510

Attachment 433427: Patch

https://bugs.webkit.org/attachment.cgi?id=433427&action=review




--- Comment #29 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 433427
  --> https://bugs.webkit.org/attachment.cgi?id=433427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433427&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +	   Previously, B3 and Air don't recognize the zero register. This
problem has been pointed 

"B3 and Air" => "Air"

> Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp:164
> +#elif CPU(X86_64) || CPU(X86)

I think you can just have CPU(X86_64) here