[webkit-reviews] review denied: [Bug 227895] [Cairo] Don't pass the current GraphicsContext state to CairoOperations : [Attachment 433386] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 227895: [Cairo] Don't pass the current GraphicsContext state to
CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=227895

Attachment 433386: Patch

https://bugs.webkit.org/attachment.cgi?id=433386&action=review




--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 433386
  --> https://bugs.webkit.org/attachment.cgi?id=433386
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433386&action=review

>>
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cp
p:672
>> +	append(createCommand<DrawEllipse>(rect));
> 
> How does the replay context get hold of all the relevant state that's not
included in the PaintingOperation structs anymore but is then used in
Cairo::drawEllipse() or other similar functions?

Good point. CairoOperationRecorder::updateState should call
GraphicsContextCairo::updateState. Will fix. Thank you.