[webkit-reviews] review granted: [Bug 227896] PUA characters have the wrong advance in the fast text codepath : [Attachment 433389] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 227896: PUA characters have the wrong advance in the fast text codepath
https://bugs.webkit.org/show_bug.cgi?id=227896

Attachment 433389: Patch

https://bugs.webkit.org/attachment.cgi?id=433389&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 433389
  --> https://bugs.webkit.org/attachment.cgi?id=433389
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433389&action=review

> Source/WebCore/platform/graphics/FontCascade.h:254
> +    static bool treatAsSpace(UChar32 c) { return c == ' ' || c == '\t' || c
== '\n' || c == noBreakSpace; }

I'm confused why the silent truncation wasn't a compiler error??

> LayoutTests/fast/text/pua-charactersTreatedAsSpace-expected.html:16
> +This test passes if you see a particular pattern of black boxes below.

particular but indescribable?