[webkit-reviews] review granted: [Bug 216755] [WebCrypto] Support Elliptic Curve P-521 on Mac : [Attachment 433065] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 216755: [WebCrypto] Support Elliptic Curve P-521 on Mac
https://bugs.webkit.org/show_bug.cgi?id=216755

Attachment 433065: Patch

https://bugs.webkit.org/attachment.cgi?id=433065&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 433065
  --> https://bugs.webkit.org/attachment.cgi?id=433065
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433065&action=review

> Source/WebCore/crypto/mac/CryptoKeyECMac.cpp:62
> +	   return size == 133;

It would be nice if these were given names instead of just magic numbers.  Or
they could be calculated from constexpr expressions.

> Source/WebCore/crypto/mac/CryptoKeyECMac.cpp:78
> +	   return size == 66;

ditto.