[webkit-reviews] review denied: [Bug 227509] Add Air opcode add/sub-and-shift for ARM64 and select this instruction in Air : [Attachment 433077] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 7 15:08:25 PDT 2021
Saam Barati <sbarati at apple.com> has denied Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 227509: Add Air opcode add/sub-and-shift for ARM64 and select this
instruction in Air
https://bugs.webkit.org/show_bug.cgi?id=227509
Attachment 433077: Patch
https://bugs.webkit.org/attachment.cgi?id=433077&action=review
--- Comment #12 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 433077
--> https://bugs.webkit.org/attachment.cgi?id=433077
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=433077&action=review
> Source/JavaScriptCore/b3/B3LowerToAir.cpp:2608
> + return Air::Nop;
nit: I'd return Oops to be consistent with tryOpcodeForType
> Source/JavaScriptCore/b3/B3LowerToAir.cpp:2614
> + if (!isValidForm(opcode, Arg::Tmp, Arg::Imm, Arg::Imm,
Arg::Tmp))
Am I missing something, or is this patch doing anything? Aren't all your
instructions you added of the form: "Tmp, Tmp, Imm, Tmp"?
More information about the webkit-reviews
mailing list