[webkit-reviews] review granted: [Bug 227603] Provide SPI for clients to override just the contextmenu preview instead of the entire `UIContextMenuConfiguration` : [Attachment 432753] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 1 17:39:13 PDT 2021
Wenson Hsieh <wenson_hsieh at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 227603: Provide SPI for clients to override just the contextmenu preview
instead of the entire `UIContextMenuConfiguration`
https://bugs.webkit.org/show_bug.cgi?id=227603
Attachment 432753: Patch
https://bugs.webkit.org/attachment.cgi?id=432753&action=review
--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 432753
--> https://bugs.webkit.org/attachment.cgi?id=432753
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=432753&action=review
> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:185
> +- (UIViewController *)_webView:(WKWebView *)webView
contextMenuPreviewForElement:(WKContextMenuElementInfo *)elementInfo
WK_API_AVAILABLE(ios(WK_IOS_TBA));
I'd maybe call this `-_webView:contextMenuContentPreviewForElement:` to match
the wording in `UIContextMenuContentPreviewProvider`.
Since this is going into iOS 15 and we've already replaced all the TBA macros
for iOS 15/macOS 12, I think we should also make this `ios(15.0)` from the
start.
More information about the webkit-reviews
mailing list