[webkit-reviews] review granted: [Bug 227596] REGRESSION (r279466): [Big Sur] webgl/1.0.3/conformance & webgl/2.0.0/conformance are failing : [Attachment 432749] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 227596: REGRESSION (r279466):  [Big Sur] webgl/1.0.3/conformance &
webgl/2.0.0/conformance are failing
https://bugs.webkit.org/show_bug.cgi?id=227596

Attachment 432749: Patch

https://bugs.webkit.org/attachment.cgi?id=432749&action=review




--- Comment #4 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 432749
  --> https://bugs.webkit.org/attachment.cgi?id=432749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432749&action=review

This seems like a good solution; didn't realize these options could be changed
per-shader. r+ once this builds and passes tests.

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm:603
> +	       //Fastmath on downlevel Intel causes some issues (Webkit bug
227596)

Space after //.